On 09.09.25 18:06, Michel Dänzer wrote: > On 02.09.25 18:53, Alex Deucher wrote: >> Older GPUs did not support memory protection, so the kernel >> driver would validate the command submissions (CS) from userspace >> to avoid the GPU accessing any memory it shouldn't. >> >> Change any error messages in that validatio to dev_warn_once() to >> avoid spamming the kernel log in the event of a bad CS. If users >> see any of these messages they should report them to the user space >> component, which in most cases is mesa >> (https://gitlab.freedesktop.org/mesa/mesa/-/issues). > > As discussed in the "evergreen_packet3_check:... radeon 0000:1d:00.0: vbo > resource seems too big for the bo" thread, based on similar rationale, these > should arguably rather use some (preferably non-once) dbg variant.
While dev_warn_once might really be the best compromise for the specific case discussed in that other thread, my argument still applies to other cases which are followed by returning an error to user space, since that surely results in a corresponding user-space failure. -- Earthling Michel Dänzer \ GNOME / Xwayland / Mesa developer https://redhat.com \ Libre software enthusiast
