On 9/11/25 22:52, David Hildenbrand wrote: > On 11.09.25 14:49, Balbir Singh wrote: >> On 9/11/25 21:45, David Hildenbrand wrote: >>> On 08.09.25 02:04, Balbir Singh wrote: >>>> Add routines to support allocation of large order zone device folios >>>> and helper functions for zone device folios, to check if a folio is >>>> device private and helpers for setting zone device data. >>>> >>>> When large folios are used, the existing page_free() callback in >>>> pgmap is called when the folio is freed, this is true for both >>>> PAGE_SIZE and higher order pages. >>>> >>>> Zone device private large folios do not support deferred split and >>>> scan like normal THP folios. >>>> >>>> Cc: Andrew Morton <a...@linux-foundation.org> >>>> Cc: David Hildenbrand <da...@redhat.com> >>>> Cc: Zi Yan <z...@nvidia.com> >>>> Cc: Joshua Hahn <joshua.hah...@gmail.com> >>>> Cc: Rakie Kim <rakie....@sk.com> >>>> Cc: Byungchul Park <byungc...@sk.com> >>>> Cc: Gregory Price <gou...@gourry.net> >>>> Cc: Ying Huang <ying.hu...@linux.alibaba.com> >>>> Cc: Alistair Popple <apop...@nvidia.com> >>>> Cc: Oscar Salvador <osalva...@suse.de> >>>> Cc: Lorenzo Stoakes <lorenzo.stoa...@oracle.com> >>>> Cc: Baolin Wang <baolin.w...@linux.alibaba.com> >>>> Cc: "Liam R. Howlett" <liam.howl...@oracle.com> >>>> Cc: Nico Pache <npa...@redhat.com> >>>> Cc: Ryan Roberts <ryan.robe...@arm.com> >>>> Cc: Dev Jain <dev.j...@arm.com> >>>> Cc: Barry Song <bao...@kernel.org> >>>> Cc: Lyude Paul <ly...@redhat.com> >>>> Cc: Danilo Krummrich <d...@kernel.org> >>>> Cc: David Airlie <airl...@gmail.com> >>>> Cc: Simona Vetter <sim...@ffwll.ch> >>>> Cc: Ralph Campbell <rcampb...@nvidia.com> >>>> Cc: Mika Penttilä <mpent...@redhat.com> >>>> Cc: Matthew Brost <matthew.br...@intel.com> >>>> Cc: Francois Dugast <francois.dug...@intel.com> >>>> >>>> Signed-off-by: Balbir Singh <balb...@nvidia.com> >>>> --- >>> >>> You missed my comments of this patch in v3. >>> >> >> Hi, David >> >> Looks I missed your comments, just checked those were largely about >> alignment and >> integrating the code for DEVICE_COHERENT and DEVICE_PRIVATE cases into >> similar looking >> bits for zone device folio free and code-alignment. I'll take a look and >> update as needed. > > Yes, and the confusing folio->mapping = NULL that I cannot connect to THP > support. >
I can remove that, let me reunify those bits, seems relatively straight forward Balbir
