On Mon, Sep 15, 2025 at 12:11:49PM +0200, David Heidelberg wrote: > On 15/09/2025 03:29, Dmitry Baryshkov wrote: > > On Sat, Sep 13, 2025 at 09:19:48PM +0200, David Heidelberg via B4 Relay > > wrote: > > > From: Molly Sophia <mollysophia...@gmail.com> > > > > > > Novatek NT35596s is a generic DSI IC that drives command and video mode > > > panels. > > > Currently add support for the LCD panel from JDI connected with this IC, > > > as found on Xiaomi Mi Mix 2S phones. > > > > Why are you adding it to the existing driver rather than adding a new > > one? > > Hello, originally it started as a standalone driver (see v2 patchset), but > got merged due to similarities.
I'm not sure, you had to get rid of the two command sets. On the other hand, adding a new module will add a lot of boilerplate. Let's keep it as is. Please add some notes to the commit message. > > v2 patchset: > https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg404290.html > > If it's desired, I can switch it back to the standalone driver. > > > > > > > > > Signed-off-by: Molly Sophia <mollysophia...@gmail.com> > > > Signed-off-by: Arnaud Ferraris <arnaud.ferra...@collabora.com> > > > Signed-off-by: David Heidelberg <da...@ixit.cz> > > > --- > > > drivers/gpu/drm/panel/Kconfig | 7 +- > > > drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 225 > > > ++++++++++++++++++++++++- > > > 2 files changed, 222 insertions(+), 10 deletions(-) > > > > > > MODULE_AUTHOR("Sumit Semwal <sumit.sem...@linaro.org>"); > > > -MODULE_DESCRIPTION("NOVATEK NT36672A based MIPI-DSI LCD panel driver"); > > > +MODULE_AUTHOR("Molly Sophia <mollysophia...@gmail.com>"); > > > > ?? > > What's wrong with it? I thought that the module can have only one MODULE_AUTHOR declaration, I was wrong. This is fine. > > David > > > > > > +MODULE_DESCRIPTION("NOVATEK NT36672A/NT35596S based MIPI-DSI LCD panel > > > driver"); > > > MODULE_LICENSE("GPL"); > > > > > > -- > > > 2.51.0 > > > > > > > > > > -- > David Heidelberg > -- With best wishes Dmitry
