Hi
Am 12.09.25 um 18:42 schrieb Iker Pedrosa:
This patch series improves the Solomon SSD130x DRM driver by adopting
existing DRM helpers, improving code clarity, and following kernel
coding standards.
* Patch #1 moves DRM GEM framebuffer CPU access calls to make critical
sections more visible and maintainable.
* Patch #2 replaces WARN_ON with drm_WARN_ON_ONCE to prevent log spam.
* Patch #3 adopts drm_crtc_helper_mode_valid_fixed() for mode
validation.
* Patch #4 adopts drm_connector_helper_get_modes_fixed() for mode
management.
* Patch #5 enforces one assignment per line per kernel coding style.
These improvements reduce code duplication by leveraging existing DRM
infrastructure and enhance code readability without changing
functionality.
Signed-off-by: Iker Pedrosa <ikerpedro...@gmail.com>
For the series
Reviewed-by: Thomas Zimmermann <tzimmerm...@suse.de>
It should also get Javier's reviews before getting merged.
Best regards
Thomas
---
Iker Pedrosa (5):
drm/solomon: Move calls to drm_gem_fb_end_cpu*()
drm/solomon: Use drm_WARN_ON_ONCE instead of WARN_ON
drm/solomon: Simplify mode_valid() using DRM helper
drm/solomon: Simplify get_modes() using DRM helper
drm/solomon: Enforce one assignment per line
drivers/gpu/drm/solomon/ssd130x.c | 77 +++++++++++++++------------------------
1 file changed, 29 insertions(+), 48 deletions(-)
---
base-commit: c571cb70e1ed43ee543c70151e61a001ab2eefa2
change-id: 20250912-improve-ssd130x-b45b89ff4693
Best regards,
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
