Re: [PATCH 02/12] drm/ast: Move mode-detection helpers to Gen2 source files

[Jocelyn Falempe]

On 16/09/2025 17:26, Thomas Zimmermann wrote:

Wide-screen modes are only available on Gen2 and later. Move the
detection helpers to the appropriate source file.

Thanks, it looks good to me.

Reviewed-by: Jocelyn Falempe <jfale...@redhat.com>

Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>
---
  drivers/gpu/drm/ast/ast_2100.c | 31 +++++++++++++++++++++++++++++++
  drivers/gpu/drm/ast/ast_drv.h  |  2 ++
  drivers/gpu/drm/ast/ast_main.c | 27 ---------------------------
  3 files changed, 33 insertions(+), 27 deletions(-)

diff --git a/drivers/gpu/drm/ast/ast_2100.c b/drivers/gpu/drm/ast/ast_2100.c
index 829e3b8b0d19..16a279ec8351 100644
--- a/drivers/gpu/drm/ast/ast_2100.c
+++ b/drivers/gpu/drm/ast/ast_2100.c
@@ -386,3 +386,34 @@ int ast_2100_post(struct ast_device *ast)

return 0;

  }
+
+/*
+ * Widescreen detection
+ */
+
+/* Try to detect WSXGA+ on Gen2+ */
+bool __ast_2100_detect_wsxga_p(struct ast_device *ast)
+{
+       u8 vgacrd0 = ast_get_index_reg(ast, AST_IO_VGACRI, 0xd0);
+
+       if (!(vgacrd0 & AST_IO_VGACRD0_VRAM_INIT_BY_BMC))
+               return true;
+       if (vgacrd0 & AST_IO_VGACRD0_IKVM_WIDESCREEN)
+               return true;
+
+       return false;
+}
+
+/* Try to detect WUXGA on Gen2+ */
+bool __ast_2100_detect_wuxga(struct ast_device *ast)
+{
+       u8 vgacrd1;
+
+       if (ast->support_fullhd) {
+               vgacrd1 = ast_get_index_reg(ast, AST_IO_VGACRI, 0xd1);
+               if (!(vgacrd1 & AST_IO_VGACRD1_SUPPORTS_WUXGA))
+                       return true;
+       }
+
+       return false;
+}
diff --git a/drivers/gpu/drm/ast/ast_drv.h b/drivers/gpu/drm/ast/ast_drv.h
index 482d1eb79d64..c75600981251 100644
--- a/drivers/gpu/drm/ast/ast_drv.h
+++ b/drivers/gpu/drm/ast/ast_drv.h
@@ -421,6 +421,8 @@ extern const struct ast_vbios_dclk_info 
ast_2000_dclk_table[];

/* ast_2100.c */

  int ast_2100_post(struct ast_device *ast);
+bool __ast_2100_detect_wsxga_p(struct ast_device *ast);
+bool __ast_2100_detect_wuxga(struct ast_device *ast);

/* ast_2300.c */

  int ast_2300_post(struct ast_device *ast);
diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c
index 3eea6a6cdacd..1678845274c7 100644
--- a/drivers/gpu/drm/ast/ast_main.c
+++ b/drivers/gpu/drm/ast/ast_main.c
@@ -36,33 +36,6 @@

#include "ast_drv.h" -/* Try to detect WSXGA+ on Gen2+ */

-static bool __ast_2100_detect_wsxga_p(struct ast_device *ast)
-{
-       u8 vgacrd0 = ast_get_index_reg(ast, AST_IO_VGACRI, 0xd0);
-
-       if (!(vgacrd0 & AST_IO_VGACRD0_VRAM_INIT_BY_BMC))
-               return true;
-       if (vgacrd0 & AST_IO_VGACRD0_IKVM_WIDESCREEN)
-               return true;
-
-       return false;
-}
-
-/* Try to detect WUXGA on Gen2+ */
-static bool __ast_2100_detect_wuxga(struct ast_device *ast)
-{
-       u8 vgacrd1;
-
-       if (ast->support_fullhd) {
-               vgacrd1 = ast_get_index_reg(ast, AST_IO_VGACRI, 0xd1);
-               if (!(vgacrd1 & AST_IO_VGACRD1_SUPPORTS_WUXGA))
-                       return true;
-       }
-
-       return false;
-}
-
  static void ast_detect_widescreen(struct ast_device *ast)
  {
        ast->support_wsxga_p = false;