Hi,

On 19/09/2025 18:42, Marek Vasut wrote:
> On 9/19/25 5:21 PM, Tomi Valkeinen wrote:
> 
> Hello Tomi,
> 
>>>> On 05/09/2025 00:01, Marek Vasut wrote:
>>>>> This controller can have both bridges and panels connected to it. In
>>>>> order to describe panels properly in DT, pull in dsi-controller.yaml
>>>>> and disallow only unevaluatedProperties, because the panel node is
>>>>> optional. Include example binding with panel.
>>>>>
>>>>> Signed-off-by: Marek Vasut <[email protected]>
>>>>> ---
>>>>> Cc: Conor Dooley <[email protected]>
>>>>> Cc: David Airlie <[email protected]>
>>>>> Cc: Geert Uytterhoeven <[email protected]>
>>>>> Cc: Kieran Bingham <[email protected]>
>>>>> Cc: Krzysztof Kozlowski <[email protected]>
>>>>> Cc: Laurent Pinchart <[email protected]>
>>>>> Cc: Neil Armstrong <[email protected]>
>>>>> Cc: Rob Herring <[email protected]>
>>>>> Cc: Robert Foss <[email protected]>
>>>>> Cc: Simona Vetter <[email protected]>
>>>>> Cc: Thomas Zimmermann <[email protected]>
>>>>> Cc: Tomi Valkeinen <[email protected]>
>>>>> Cc: [email protected]
>>>>> Cc: [email protected]
>>>>> Cc: [email protected]
>>>>> ---
>>>>> V2: Drop the dsi0: and dsi1: controller labels
>>>>> ---
>>>>>    .../display/bridge/renesas,dsi-csi2-tx.yaml   | 53 +++++++++++++
>>>>> +++++-
>>>>>    1 file changed, 51 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/display/bridge/
>>>>> renesas,dsi-csi2-tx.yaml b/Documentation/devicetree/bindings/display/
>>>>> bridge/renesas,dsi-csi2-tx.yaml
>>>>> index c167795c63f64..51d685ed82891 100644
>>>>> --- a/Documentation/devicetree/bindings/display/bridge/renesas,dsi-
>>>>> csi2-tx.yaml
>>>>> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dsi-
>>>>> csi2-tx.yaml
>>>>> @@ -14,6 +14,9 @@ description: |
>>>>>      R-Car Gen4 SoCs. The encoder can operate in either DSI or CSI-2
>>>>> mode, with up
>>>>>      to four data lanes.
>>>>>    +allOf:
>>>>> +  - $ref: /schemas/display/dsi-controller.yaml#
>>>>> +
>>>>
>>>> Did you try with a bridge? dsi-controller.yaml only allows a panel. I
>>>> think I discussed this with someone not long ago, but I couldn't find
>>>> any patch sent for that.
>>> Nope, I only have these two 5" and 7" RPi Display 2 panels.
>>
>> Ok. My point was just that the dsi-controller.yaml doesn't allow
>> "bridge" node (you can just rename the panel to bridge to test). I
>> thought someone (I just can't remember who was it =) will send a patch
>> for it, but I think that hasn't happened.
> Do you want me to drop the bridge part from the commit message (I assume
> yes) ?
> 
> Any other change I should do before sending a V3 ?

As we found out, this has been fixed in linux-next. For this, and the
rest in this series:

Reviewed-by: Tomi Valkeinen <[email protected]>

 Tomi

Reply via email to