On 9/22/2025 5:40 PM, Dmitry Baryshkov wrote: > On Mon, Sep 22, 2025 at 04:04:42PM +0800, Xiangxu Yin wrote: >> On 9/20/2025 12:45 AM, Dmitry Baryshkov wrote: >>> On Fri, Sep 19, 2025 at 10:24:22PM +0800, Xiangxu Yin wrote: >>>> Move resets to qmp_phy_cfg for per-PHY customization. Keep legacy DT >>>> path on the old hardcoded list; non-legacy path uses cfg->reset_list. >>> Why? Start your commit messages with the description of the issue that >>> you are trying to solve. >> >> The original reset list only works for USB-only PHYs. USB3DP PHYs need >> different >> reset names like "dp_phy", so they use a separate list. Moving resets to >> qmp_phy_cfg enables per-PHY config without special-case logic in DT parsing. >> I will update commit msg with issue description. >> >> Or do you suggest using (offs->dp_serdes != 0) to choose the reset list >> instead >> using new attributes? > You can't because othe DP PHYs supported by this driver will use 3 > resets: phy, phy_phy and dp_phy.
Ok, then I will update commit msg with issue description. >> >>>> Signed-off-by: Xiangxu Yin <xiangxu....@oss.qualcomm.com> >>>> --- >>>> drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 18 +++++++++++++++--- >>>> 1 file changed, 15 insertions(+), 3 deletions(-) >>>>
