Hi Marek, > -----Original Message----- > From: Marek Vasut <marek.vasut+rene...@mailbox.org> > Sent: 22 September 2025 19:55 > Subject: [PATCH 4/9] drm/rcar-du: dsi: Clean up CLOCKSET1 CLKINSEL macros > > Introduce CLOCKSET1_CLKINSEL_MASK macro and remove bitshift from values to > make this bitfield usable > with FIELD_PREP(). There are no users of this bitfield, hence no updates to > the DSI driver. > > Do not convert bits and bitfields to BIT() and GENMASK() yet, to be consisten > with the current style. > Conversion to BIT() and GENMASK() macros is done at the very end of this > series in the last two > patches. > > Signed-off-by: Marek Vasut <marek.vasut+rene...@mailbox.org> > --- > Cc: David Airlie <airl...@gmail.com> > Cc: Geert Uytterhoeven <geert+rene...@glider.be> > Cc: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > Cc: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> > Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > Cc: Magnus Damm <magnus.d...@gmail.com> > Cc: Maxime Ripard <mrip...@kernel.org> > Cc: Simona Vetter <sim...@ffwll.ch> > Cc: Thomas Zimmermann <tzimmerm...@suse.de> > Cc: Tomi Valkeinen <tomi.valkeinen+rene...@ideasonboard.com> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-renesas-...@vger.kernel.org > --- > NOTE: No functional change expected, this is a preparatory patch which partly > removes macros which > evaluate to zeroes from rcar_mipi_dsi_regs.h . > The other patches in this series proceed with that job, piece by piece, to > make it all reviewable. > --- > drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h > b/drivers/gpu/drm/renesas/rcar- > du/rcar_mipi_dsi_regs.h > index c2cb06ef144ed..808861aaf3bfe 100644 > --- a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h > +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h > @@ -268,9 +268,10 @@ > #define CLOCKSET1 0x101c > #define CLOCKSET1_LOCK_PHY (1 << 17) > #define CLOCKSET1_CLKSEL (1 << 8) > -#define CLOCKSET1_CLKINSEL_EXTAL (0 << 2)
0 > -#define CLOCKSET1_CLKINSEL_DIG (1 << 2) 4 > -#define CLOCKSET1_CLKINSEL_DU (1 << 3) 8 > +#define CLOCKSET1_CLKINSEL_MASK (3 << 2) > +#define CLOCKSET1_CLKINSEL_EXTAL 0 > +#define CLOCKSET1_CLKINSEL_DIG 1 > +#define CLOCKSET1_CLKINSEL_DU 2 Looks like this patch breaks existing functionality, as the macro values are different. Cheers, Biju
