Hi
Am 23.09.25 um 10:27 schrieb Madhur Kumar:
Use strscpy() instead of strcpy() to copy "[fbcon]" into fb->comm.
This prevents possible buffer overflows and ensures proper NUL
termination.
Signed-off-by: Madhur Kumar <madhurkumar...@gmail.com>
v2: Fixed typo in commit message
---
drivers/gpu/drm/drm_fb_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 11a5b60cb9ce..0cd7c3280243 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -1651,7 +1651,7 @@ static int drm_fb_helper_single_fb_probe(struct
drm_fb_helper *fb_helper)
if (ret < 0)
return ret;
- strcpy(fb_helper->fb->comm, "[fbcon]");
+ strscpy(fb_helper->fb->comm, "[fbcon]", sizeof(fb_helper->fb->comm));
If anyone ever makes comm a pointer, this code will fail.
It's therefore better to leave out the size argument. strscpy() will
then detect the size and verify that dst is an array. See the docs and
define of strscpy() [1] for details.
Best regards
Thomas
info = fb_helper->info;
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
