LCD_CLASS_DEVICE is the user-controlled option that enables the LCD
display subsystem. Do not select it from fbdev drivers. Selecting it
from drivers can lead to cyclic dependencies within the config.

Some guidelines for using select can be found in the kernel docs at [1].

Signed-off-by: Thomas Zimmermann <[email protected]>
Link: 
https://elixir.bootlin.com/linux/v6.16/source/Documentation/kbuild/kconfig-language.rst#L147
 # [1]
---
 drivers/video/fbdev/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 6cea1449b4c5..0bea7eae6161 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -126,9 +126,9 @@ config FB_ACORN
 config FB_CLPS711X
        tristate "CLPS711X LCD support"
        depends on FB && (ARCH_CLPS711X || COMPILE_TEST)
+       depends on LCD_CLASS_DEVICE
        select FB_IOMEM_HELPERS
        select FB_MODE_HELPERS
-       select LCD_CLASS_DEVICE
        select VIDEOMODE_HELPERS
        help
          Say Y to enable the Framebuffer driver for the Cirrus Logic
@@ -150,7 +150,7 @@ config FB_IMX
        tristate "Freescale i.MX1/21/25/27 LCD support"
        depends on FB && HAVE_CLK && HAS_IOMEM
        depends on ARCH_MXC || COMPILE_TEST
-       select LCD_CLASS_DEVICE
+       depends on LCD_CLASS_DEVICE
        select FB_IOMEM_HELPERS
        select FB_MODE_HELPERS
        select VIDEOMODE_HELPERS
-- 
2.51.0

Reply via email to