Re: [PATCH] drm/draw: fix color truncation in drm_draw_fill24

[Jocelyn Falempe]

On 03/10/2025 12:33, Francesco Valla wrote:

The color parameter passed to drm_draw_fill24() was truncated to 16
bits, leading to an incorrect color drawn to the target iosys_map.
Fix this behavior, widening the parameter to 32 bits.

Merged to drm-misc-fixes.

Thanks for your contribution.

--

Jocelyn

Fixes: 31fa2c1ca0b2 ("drm/panic: Move drawing functions to drm_draw")

Signed-off-by: Francesco Valla <france...@valla.it>
---
  drivers/gpu/drm/drm_draw.c          | 2 +-
  drivers/gpu/drm/drm_draw_internal.h | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_draw.c b/drivers/gpu/drm/drm_draw.c
index 
9dc0408fbbeadbe8282a2d6b210e0bfb0672967f..5b956229c82fb6e232e3342705a226c8e14c8568
 100644
--- a/drivers/gpu/drm/drm_draw.c
+++ b/drivers/gpu/drm/drm_draw.c
@@ -127,7 +127,7 @@ EXPORT_SYMBOL(drm_draw_fill16);

void drm_draw_fill24(struct iosys_map *dmap, unsigned int dpitch,

                     unsigned int height, unsigned int width,
-                    u16 color)
+                    u32 color)
  {
        unsigned int y, x;

diff --git a/drivers/gpu/drm/drm_draw_internal.h b/drivers/gpu/drm/drm_draw_internal.h

index 
f121ee7339dc11537f677c833f0ee94fe0e799cd..20cb404e23ea6263b535ea2b81b25f84c37be8a2
 100644
--- a/drivers/gpu/drm/drm_draw_internal.h
+++ b/drivers/gpu/drm/drm_draw_internal.h
@@ -47,7 +47,7 @@ void drm_draw_fill16(struct iosys_map *dmap, unsigned int 
dpitch,

void drm_draw_fill24(struct iosys_map *dmap, unsigned int dpitch,

                     unsigned int height, unsigned int width,
-                    u16 color);
+                    u32 color);

void drm_draw_fill32(struct iosys_map *dmap, unsigned int dpitch,

                     unsigned int height, unsigned int width,

---
base-commit: e406d57be7bd2a4e73ea512c1ae36a40a44e499e
change-id: 20251003-drm_draw_fill24_fix-ea52d32a933d

Best regards,