On Thu, 9 Oct 2025 at 13:41, Harry Wentland <[email protected]> wrote: > > > > On 2025-10-09 12:19, Christian König wrote: > > On 09.10.25 17:06, Ard Biesheuvel wrote: > >> From: Ard Biesheuvel <[email protected]> > >> > >> Test the existing CPP macro _LINUX_FPU_COMPILATION_UNIT, which is set > >> when building source files that are permitted to use floating point, > >> in the implementation of DC_FP_START/END so that those are only usable > >> in non-FP code. This is a requirement of the generic kernel mode FPU > >> API, as some architectures (i.e., arm64) cannot safely enable FP codegen > >> in arbitrary code. > > > > If I'm not completely mistaken that is actually an issue on basically all > > architectures, at least x86 is affected as well if I'm not completely > > mistaken. > > > >> Cc: Austin Zheng <[email protected]> > >> Cc: Jun Lei <[email protected]> > >> Cc: Harry Wentland <[email protected]> > >> Cc: Leo Li <[email protected]> > >> Cc: Rodrigo Siqueira <[email protected]> > >> Cc: Alex Deucher <[email protected]> > >> Cc: "Christian König" <[email protected]> > >> Cc: [email protected] > >> Cc: [email protected] > >> Signed-off-by: Ard Biesheuvel <[email protected]> > > > > Anyway, patch looks sane to me but I'm not so deep in the DC code to fully > > judge. > > > > Fell free to add Acked-by: Christian König <[email protected]>, but > > Harry and Leo need to take a look. > > > > Thanks. Good safe-guard. Flags a bunch of issues in the > current code. Let me fix them before merging it. > > Reviewed-by: Harry Wentland <[email protected]> >
Thanks. I already fixed a bunch here: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ddbfac152830e38d488ff8e45ab7eaf5d72f8527
