On Thu, 9 Oct 2025 11:29:14 +0100 Steven Price <[email protected]> wrote:
> On 08/10/2025 11:51, Ketil Johnsen wrote: > > Currently the Panthor driver needs the GPU to be powered down > > between suspend and resume. If this is not done, then the > > MCU_CONTROL register will be preserved as AUTO, which again will > > cause a premature FW boot on resume. The FW will go directly into > > fatal state in this case. > > > > This case needs to be handled as there is no guarantee that the > > GPU will be powered down after the suspend callback on all platforms. > > > > The fix is to call panthor_fw_stop() in "pre-reset" path to ensure > > the MCU_CONTROL register is cleared (set DISABLE). This matches > > well with the already existing call to panthor_fw_start() from the > > "post-reset" path. > > > > Signed-off-by: Ketil Johnsen <[email protected]> > > Reviewed-by: Steven Price <[email protected]> > > Do we need a Fixes tag? Or is this only actually an issue on newer GPUs? I think it'd be good to have a Fixes tag, if it's known to be the right thing to do after a HALT, even if it's not needed on the GPUs currently supported by this driver.
