On Mon, Sep 29, 2025 at 02:23:01AM +0200, Marek Vasut wrote:
>On 9/26/25 7:57 AM, Peng Fan wrote:
>
>Hello Peng,
>
>> On Thu, Sep 25, 2025 at 10:38:31PM +0200, Marek Vasut wrote:
>> > The instance of the GPU populated in i.MX95 is the G310, describe this
>> > GPU in the DT. Include dummy GPU voltage regulator and OPP tables.
>> >
>> >
>> > + gpu: gpu@4d900000 {
>> > + compatible = "nxp,imx95-mali", "arm,mali-valhall-csf";
>> > + reg = <0 0x4d900000 0 0x480000>;
>> > + clocks = <&scmi_clk IMX95_CLK_GPU>, <&scmi_clk
>> > IMX95_CLK_GPUAPB>;
>> > + clock-names = "core", "coregroup";
>> > + interrupts = <GIC_SPI 289 IRQ_TYPE_LEVEL_HIGH>,
>> > + <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>,
>> > + <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
>> > + interrupt-names = "job", "mmu", "gpu";
>> > + mali-supply = <&gpu_fixed_reg>;
>> > + operating-points-v2 = <&gpu_opp_table>;
>> > + power-domains = <&scmi_devpd IMX95_PD_GPU>;
>> > + #cooling-cells = <2>;
>> > + dynamic-power-coefficient = <1013>;
>>
>> Sorry for my ignorance, would you please share how to get the value?
>Copy-pasted from NXP downstream kernel fork DT bindings, see:
>
>https://github.com/nxp-imx/linux-imx.git
>
>11495de7c24a ("MGS-7621-4 dts: gpu: update devfreq para")
Hi Marek,
1. this "mali: gpu@4d900000" label can be found in this commit you showed.
please correct this to be compatible with the downstream and upstream kernel
2. the compatible string is different from our downstream kernel,
also you dropped the "nxp,imx95-mali" compatible patch in the panthor
driver, why? this will impact the mali property driver too, which
has already been used in many customer project.
3. the number of frequency in opp-table is only one, but there are two clocks
in clocks property, this really make people confused.
CLK/CLK_COREGROUP/CLK_STACK in i.MX95 are from the same source
<&scmi_clk IMX95_CLK_GPU>, the other clock <&scmi_clk IMX95_CLK_GPUAPB>
is always-on APB clock, which can't be changed by A-cores, and has been removed
from clocks property in the latest release.
