Hello， At 2025-10-12 22:20:01, "Alok Tiwari" <[email protected]> wrote: >The vop2_plane_atomic_check() function incorrectly checks >drm_rect_width(dest) twice instead of verifying both width and height. >Fix the second condition to use drm_rect_height(dest) so that invalid >destination rectangles with height < 4 are correctly rejected. > >Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") >Signed-off-by: Alok Tiwari <[email protected]> >--- >v1 -> v2 >fix typo drm_rect_heigh -> drm_rect_height >--- > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >index b50927a824b4..7ec7bea5e38e 100644 >--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >@@ -1031,7 +1031,7 @@ static int vop2_plane_atomic_check(struct drm_plane >*plane, > return format; > > if (drm_rect_width(src) >> 16 < 4 || drm_rect_height(src) >> 16 < 4 || >- drm_rect_width(dest) < 4 || drm_rect_width(dest) < 4) { >+ drm_rect_width(dest) < 4 || drm_rect_height(dest) < 4) { > drm_err(vop2->drm, "Invalid size: %dx%d->%dx%d, min size is > 4x4\n", > drm_rect_width(src) >> 16, drm_rect_height(src) >> 16, > drm_rect_width(dest), drm_rect_height(dest)); >--
Reviewed-by: Andy Yan <[email protected]> Thanks. >2.50.1
