On Tue, Oct 14, 2025 at 12:06:13PM +0530, Ayushi Makhija wrote: > On 10/6/2025 3:46 PM, Dmitry Baryshkov wrote: > > On Mon, Oct 06, 2025 at 07:09:24AM +0530, Ayushi Makhija wrote: > >> Add anx7625 DSI to DP bridge device node. > >> > >> Signed-off-by: Ayushi Makhija <[email protected]> > >> Reviewed-by: Dmitry Baryshkov <[email protected]> > >> --- > >> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 170 ++++++++++++++++++++++ > >> 1 file changed, 170 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts > >> b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts > >> index 891e49602c97..5d4040376857 100644 > >> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts > >> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts > >> @@ -24,6 +24,64 @@ chosen { > >> stdout-path = "serial0:115200n8"; > >> }; > >> > >> + vreg_12p0: vreg-12p0-regulator { > > > > Why are these nodes not in a correct place? Also, why are they named > > differently from all other regulators in this board file? > > Hi Dmitry, > > Will keep the nodes at their correct place based on alphabetical order in > next patchset. > Similar names I have used in LeMans for these regulators. We have kept these > name based on the information of these regulator we got from SW doc for > monaco.
There is a slight difference between two DTSIs. LeMans RIDE uses vreg-foo-regulator, while qcs8300-ride.dtsi got regulator-usb2-vbus (which is close to what other platforms use). I think we should also be using regulator-vreg-12p0. -- With best wishes Dmitry
