On Mon, Oct 06, 2025 at 06:41:43PM +0200, Javier Garcia wrote: > This patch wraps the relevant code blocks with `IS_ENABLED(ifdef > CONFIG_FB_DEVICE)`,
stray "ifdef " > allowing the driver to be built and used even if CONFIG_FB_DEVICE is not > selected. The driver built fine without FB_DEVICE already before, doesn't it? > The sysfs only give access to show some controller and cursor registers so > it's not needed to allow driver works correctly. > > This align with Documentation/drm/todo.rst > "Remove driver dependencies on FB_DEVICE" Given the above, I still don't understand that. (But maybe this can be fixed by Helge's request to improve the commit message.) > Signed-off-by: Javier Garcia <[email protected]> > --- > v1 -> v2: > * Fix error and improvement , thanks Uwe Kleine-Koenig. > * v1 > https://lore.kernel.org/lkml/[email protected] > > > drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c > b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c > index ade88e7bc760..dc99b8c9ff0f 100644 > --- a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c > +++ b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c > @@ -17,6 +17,7 @@ > #include <linux/module.h> > #include <linux/init.h> > #include <linux/interrupt.h> > +#include "linux/kconfig.h" I didn't need that during my build tests, also don't use "" here, but <>. > #include <linux/pci.h> > #include <linux/of.h> > #include <linux/of_address.h> > [...] Best regards Uwe
signature.asc
Description: PGP signature
