On 2025-09-26 at 11:24 +1000, Alexandre Courbot <[email protected]> wrote... > On Mon Sep 22, 2025 at 8:30 PM JST, Alistair Popple wrote: > <snip> > > diff --git a/drivers/gpu/nova-core/gsp/fw.rs > > b/drivers/gpu/nova-core/gsp/fw.rs > > index dd1e7fc85d85..7f4fe684ddaf 100644 > > --- a/drivers/gpu/nova-core/gsp/fw.rs > > +++ b/drivers/gpu/nova-core/gsp/fw.rs > <snip> > > +pub(crate) use r570_144::{ > > + // GSP firmware constants > > + GSP_FW_WPR_META_MAGIC, > > + GSP_FW_WPR_META_REVISION, > > +}; > > Why do these need to be re-exported? I don't think we are using them > outside of fw.rs.
Thanks, they don't now that the structs are constructed in fw.rs. Will remove them.
