On 10/16/2025, Marek Vasut wrote: > On 10/16/25 8:32 AM, Liu Ying wrote: > > Hello Liu,
Hello Marek, > >> +++ b/drivers/gpu/drm/imx/dc/Kconfig >> @@ -1,6 +1,7 @@ >> config DRM_IMX8_DC >> tristate "Freescale i.MX8 Display Controller Graphics" >> depends on DRM && COMMON_CLK && OF && (ARCH_MXC || COMPILE_TEST) >> + depends on IMX_SCU > Can the SCU dependency be made optional, I don't think this can be done. If you grep 'depends on IMX_SCU' in kernel, you may find a handful of existing dependancies. > or per-module, Well, DRM_IMX8_DC(for the imx8_dc_drm module) depends on IMX_SCU just as this patch does. > or somehow abstracted out (via regmap?), Like I replied to your i.MX95 DC patch series's cover letter, SCU accesses registers via Cortex-M core instead of Cortex-A core IIUC. I really don't know how to abstract IMX_SCU out, especially via regmap. > so iMX95 support can be added into the driver easily too ? Like I replied to your i.MX95 DC patch series, I think i.MX95 DC support can be in drivers/gpu/drm/imx/dc, but it should be in a separate module (something like imx95_dc_drm) plus an additional common module(like imx_dc_drm_common). -- Regards, Liu Ying
