On Mon, Oct 20, 2025 at 11:58:45AM +0200, Alexander Stein wrote: > Use dev_err_probe() to add a reason for deferred probe. This can > especially happen on lcdif3 which uses hdmi_tx_phy for 'pix' clock > > Reviewed-by: Liu Ying <[email protected]> > Reviewed-by: Marco Felsch <[email protected]> > Signed-off-by: Alexander Stein <[email protected]> > --- > Changes in v2: > * Collected Liu's and Marcos' R-b
Reviewed-by: Frank Li <[email protected]> > > drivers/gpu/drm/mxsfb/lcdif_drv.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c > b/drivers/gpu/drm/mxsfb/lcdif_drv.c > index fcb2a7517377e..47da1d9336b90 100644 > --- a/drivers/gpu/drm/mxsfb/lcdif_drv.c > +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c > @@ -149,15 +149,17 @@ static int lcdif_load(struct drm_device *drm) > > lcdif->clk = devm_clk_get(drm->dev, "pix"); > if (IS_ERR(lcdif->clk)) > - return PTR_ERR(lcdif->clk); > + return dev_err_probe(drm->dev, PTR_ERR(lcdif->clk), "Failed to > get pix clock\n"); > > lcdif->clk_axi = devm_clk_get(drm->dev, "axi"); > if (IS_ERR(lcdif->clk_axi)) > - return PTR_ERR(lcdif->clk_axi); > + return dev_err_probe(drm->dev, PTR_ERR(lcdif->clk_axi), > + "Failed to get axi clock\n"); > > lcdif->clk_disp_axi = devm_clk_get(drm->dev, "disp_axi"); > if (IS_ERR(lcdif->clk_disp_axi)) > - return PTR_ERR(lcdif->clk_disp_axi); > + return dev_err_probe(drm->dev, PTR_ERR(lcdif->clk_disp_axi), > + "Failed to get disp_axi clock\n"); > > platform_set_drvdata(pdev, drm); > > -- > 2.43.0 >
