On 10/22/25 2:09 PM, Joel Fernandes wrote:
On 10/22/2025 2:48 AM, Alexandre Courbot wrote:
On Tue Oct 21, 2025 at 7:35 AM JST, John Hubbard wrote:
Alex, this ".alter" method is misnamed, IMHO. Because for registers,
The One True Way (or so I claim, haha) is to have the following methods:
.read
.modify, also known as RMW (read-modify-write)
.write
"alter" never shows up in this naming scheme. I'm going to claim that
this is a bit jarring for old hardware/kernel programmers.
But it's not too late: these are only used in a very few places, and entirely
within nova-core, too.
Can I *please* send a patch to rename "alter" to "modify", perhaps?
Oh yes, although I was just thinking that this should be renamed to
`update` for consistency with regmap.
Either update or modify would be Ok with me. Update does make it sound more like
"update" works for me, too. Maybe we have a winner. Quick, let's
do it before a 4th engineer shows up! haha
I can send a patch to rename it.
a total write though for some reason. Perhaps update_fields ?
thanks,
--
John Hubbard
