Re: [PATCH 2/8] drm/i915/alpm: alpm_init() for DP2.1

[Jani Nikula]

On Thu, 23 Oct 2025, Animesh Manna <animesh.ma...@intel.com> wrote:
> Initialize mutex for DP2.1 alpm.

Let's not do that for every detect cycle.

Perhaps intel_alpm_init() needs to be split to one-time init and sink
specific init.

BR,
Jani.


>
> Cc: Jouni Högander <jouni.hogan...@intel.com>
> Signed-off-by: Animesh Manna <animesh.ma...@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c 
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index 475518b4048b..3f9cbeb215ed 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -6073,8 +6073,12 @@ intel_dp_detect(struct drm_connector *_connector,
>       if (ret == 1)
>               connector->base.epoch_counter++;
>  
> -     if (!intel_dp_is_edp(intel_dp))
> +     if (!intel_dp_is_edp(intel_dp)) {
> +             if (DISPLAY_VER(display) >= 35)
> +                     intel_alpm_init(intel_dp);
> +
>               intel_psr_init_dpcd(intel_dp);
> +     }
>  
>       intel_dp_detect_dsc_caps(intel_dp, connector);

-- 
Jani Nikula, Intel