Hi, Louis: Louis-Alexis Eyraud <[email protected]> 於 2025年10月23日 週四 上午10:32寫道： > > From: AngeloGioacchino Del Regno <[email protected]> > > Add support for the newer HDMI-TX (Encoder) v2 and DDC v2 IPs > found in MediaTek's MT8195, MT8188 SoC and their variants, and > including support for display modes up to 4k60 and for HDMI > Audio, as per the HDMI 2.0 spec. > > HDCP and CEC functionalities are also supported by this hardware, > but are not included in this commit and that also poses a slight > difference between the V2 and V1 controllers in how they handle > Hotplug Detection (HPD). > > While the v1 controller was using the CEC controller to check > HDMI cable connection and disconnection, in this driver the v2 > one does not. > > This is due to the fact that on parts with v2 designs, like the > MT8195 SoC, there is one CEC controller shared between the HDMI > Transmitter (HDMI-TX) and Receiver (HDMI-RX): before eventually > adding support to use the CEC HW to wake up the HDMI controllers > it is necessary to have support for one TX, one RX *and* for both > at the same time. > > Reviewed-by: CK Hu <[email protected]> > Signed-off-by: AngeloGioacchino Del Regno > <[email protected]> > Signed-off-by: Louis-Alexis Eyraud <[email protected]> > --- > drivers/gpu/drm/mediatek/Kconfig | 7 + > drivers/gpu/drm/mediatek/Makefile | 2 + > drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 4 + > drivers/gpu/drm/mediatek/mtk_hdmi_common.h | 9 + > drivers/gpu/drm/mediatek/mtk_hdmi_ddc_v2.c | 395 ++++++++ > drivers/gpu/drm/mediatek/mtk_hdmi_regs_v2.h | 263 +++++ > drivers/gpu/drm/mediatek/mtk_hdmi_v2.c | 1398 > +++++++++++++++++++++++++++ > 7 files changed, 2078 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/Kconfig > b/drivers/gpu/drm/mediatek/Kconfig > index > 994b48b82d447c47391122e6ff2d139edb223536..c89ae4ed2c96123684ecd357314fa2d2ba5a4433 > 100644 > --- a/drivers/gpu/drm/mediatek/Kconfig > +++ b/drivers/gpu/drm/mediatek/Kconfig > @@ -45,3 +45,10 @@ config DRM_MEDIATEK_HDMI > select DRM_MEDIATEK_HDMI_COMMON > help > DRM/KMS HDMI driver for Mediatek SoCs > + > +config DRM_MEDIATEK_HDMI_V2 > + tristate "DRM HDMI v2 IP support for MediaTek SoCs" > + depends on DRM_MEDIATEK > + select DRM_MEDIATEK_HDMI_COMMON > + help > + DRM/KMS HDMI driver for MediaTek SoCs with HDMIv2 IP >
The checkpatch show this warning. Maybe other old description just has one line, I think it's better to have more information. Please provide more information and I would modify this patch when I apply it. WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines #54: FILE: drivers/gpu/drm/mediatek/Kconfig:49: +config DRM_MEDIATEK_HDMI_V2 + tristate "DRM HDMI v2 IP support for MediaTek SoCs" + depends on DRM_MEDIATEK + select DRM_MEDIATEK_HDMI_COMMON + help + DRM/KMS HDMI driver for MediaTek SoCs with HDMIv2 IP Regards, Chun-Kuang.
