On 10/27/2025 3:28 PM, Danilo Krummrich wrote: > On 10/27/25 8:23 PM, Danilo Krummrich wrote: >> On 10/27/25 8:09 PM, Joel Fernandes wrote: >>> Why not just implement `From` and `Into` for the types missing it then, with >>> adequate comments about why such conversions are Ok for the kernel, instead >>> of >>> introducing a new trait? This is exactly what `From`/`Into` is for right? >> >> https://doc.rust-lang.org/reference/items/implementations.html#r-items.impl.trait.orphan-rule.intro > > (Sorry, I didn't mean to send the link without additional comment.) > > We can't do this due to the orphan rule, but even if we could I think a > separate > trait indicating the reason for the conversions to be valid is a good thing. >
Thanks for clarifying, yeah its not ideal then as the user of the conversion needs to remember when to use from vs from_as. I don't think its terrible, just a bit confusing. Thanks.
