In an effort to make the existing compatibles more usable, we are removing the max/min_pclk_khz form dispc_features structure and doing the supported pixel clock checks using clk_round_rate().
Changes are fully backwards compatible. - Remove max/min_pclk_khz and use clk_round_rate to validate modes - Skip OLDI mode validate through dispc_vp_mode_valid and add mode_valid hook to validate modes for OLDI bridge in tidss_oldi.c Note: - Resend to have modification in the Changelog v6->v7, correct PATCH 2/3 -> PATCH 3/3 --- Changelog v6->v7 - Remove both max/min_pclk_khz as suggested by Tomi - Use mode_valid() instead of atomic_check() - Squash patches v6 PATCH 1/3 and PATCH 3/3 which is a fix to OLDI series[1] - Minor fixes in commit message - Update commit message to include more reasoning to add Fixes tag to Patch v7 2/2 [1]: https://lore.kernel.org/all/[email protected]/ v6 patch link: https://lore.kernel.org/all/[email protected]/ Changelog v5->v6 - Drop caching logic - Add comments for tolerance value (We are targeting another series for reducing tolerance value) - Minor fixes in commit message v5 patch link: https://lore.kernel.org/all/[email protected]/ Changelog v4->v5 - Rename is_oldi_vp[] to is_ext_vp_clk[] - Store both pixel clock round_rate and attempted_rate to reduce clk_round_rate() calls while validating modes - Code changes suggested by Tomi[2] - Minor fixes in comments and commit message [2]: https://lore.kernel.org/all/[email protected]/ v4 patch link: https://lore.kernel.org/all/[email protected]/ Changelog v3->v4: - Minor cosmetic fixes in code, comments and commit message - Pick up R-by and add Fixes tag v3 patch link: https://lore.kernel.org/all/[email protected]/ Changelog v2->v3: - Add changes for OLDI - Rename max_pclk as it is misleading - Change commit message to make it more appropriate - Drop unnecessary zero initialization v2 patch link: https://lore.kernel.org/all/[email protected]/ Changelog v1->v2: - Rebase it on linux-next after OLDI support series as all of its patches are reviewed and tested and it touches one of the functions used. v1 patch link: https://lore.kernel.org/all/[email protected]/ --- Jayesh Choudhary (2): drm/tidss: Remove max_pclk_khz and min_pclk_khz from tidss display features drm/tidss: Move OLDI mode validation to OLDI bridge mode_valid hook drivers/gpu/drm/tidss/tidss_dispc.c | 87 +++++++++++------------------ drivers/gpu/drm/tidss/tidss_dispc.h | 3 - drivers/gpu/drm/tidss/tidss_drv.h | 2 + drivers/gpu/drm/tidss/tidss_oldi.c | 21 +++++++ 4 files changed, 55 insertions(+), 58 deletions(-)
