Am 28.10.25 um 10:03 schrieb Krzysztof Kozlowski: > On Mon, Oct 27, 2025 at 06:48:11PM +0100, Josua Mayer wrote: >> port property is used for linking dsi ports with dsi panels. >> Add port property to ronbo dsi panel binding. >> >> Signed-off-by: Josua Mayer <[email protected]> >> --- >> Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git >> a/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml >> b/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml >> index 04f86e0cbac91..a2dc67a87fa3b 100644 >> --- a/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml >> +++ b/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml >> @@ -13,6 +13,7 @@ properties: >> compatible: >> const: ronbo,rb070d30 >> >> + port: true > Port is never the second property. Please look at other bindings.
Some places did that ...., e.g.: Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml- compatible: Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml- enum: Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml- - mantix,mlaf057we51-x Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml- - ys,ys57pss36bh5gq Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml- Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml: port: true Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml- reg: > > Also, missing blank line Okay > and missing top-level ref for panel-common. Does this impact which properties are considered required / valid? Ronbo panel has different gpios / names from panel-common: power-gpios: similar to panel-common enable-gpios reset-gpios: common to panel-common shlr-gpios: special to ronbo updn-gpios: special to ronbo vcc-lcd-supply: similar to panel-common power-supply backlight: common to panel-common There are some other gpios in panel-common that ronbo panel does not use. Is the above relevant? Would it be correct adding the below?: maintainers: - Maxime Ripard <[email protected]> +allOf: + - $ref: panel-common.yaml# + properties: compatible: const: ronbo,rb070d30 @@ -48,5 +50,6 @@ required: - shlr-gpios - updn-gpios - vcc-lcd-supply + - port additionalProperties: false sincerely Josua Mayer
