On 10/29/2025 3:57 AM, Dmitry Baryshkov wrote: > On Tue, Oct 28, 2025 at 01:06:52PM +0800, Xiangxu Yin wrote: >> On 10/27/2025 11:26 PM, Rob Herring wrote: >>> On Fri, Oct 24, 2025 at 01:21:01PM +0800, Xiangxu Yin wrote: >>>> SM6150 uses the same DisplayPort controller as SM8150, which is already >>>> compatible with SM8350. Add the SM6150-specific compatible string and >>>> update the binding example accordingly. >>>> >>>> Signed-off-by: Xiangxu Yin <[email protected]> >>>> --- >>>> .../devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml | 10 >>>> ++++++++++ >>>> 1 file changed, 10 insertions(+) >>>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >>>> b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >>>> index >>>> 9ac24f99d3ada1c197c9654dc9babebccae972ed..ba0dea2edea98cee0826cf38b3f33361666e004a >>>> 100644 >>>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >>>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >>>> @@ -51,6 +51,16 @@ patternProperties: >>>> compatible: >>>> const: qcom,sm6150-dpu >>>> >>>> + "^displayport-controller@[0-9a-f]+$": >>>> + type: object >>>> + additionalProperties: true >>>> + properties: >>>> + compatible: >>>> + items: >>>> + - const: qcom,sm6150-dp >>>> + - const: qcom,sm8150-dp >>>> + - const: qcom,sm8350-dp >>> The actual schema will check the order. Here, just: >>> >>> compatible: >>> contains: >>> const: qcom,sm6150-dp >> >> My initial plan was to use only `qcom,sm6150-dp` with `contains` as >> suggested. >> >> But when I tried that, CHECK_DTBS schema check failed: >> ‘displayport-controller@ae90000:compatible: ['qcom,sm6150-dp', >> 'qcom,sm8150-dp', 'qcom,sm8350-dp'] is too long >> from schema $id: >> http://devicetree.org/schemas/display/msm/qcom,sm6150-mdss.yaml’‘ >> >> So, I have added all. > Please use properties: compatible: contains:
Ok, I missed the focus on the 'contains' syntax earlier. will update it in the next version. >> >>>> + >>>> "^dsi@[0-9a-f]+$": >>>> type: object >>>> additionalProperties: true >>>> >>>> -- >>>> 2.34.1 >>>>
