Re: [PATCH v8 01/10] usb: typec: Add notifier functions

[Heikki Krogerus]

Hi,

> diff --git a/include/linux/usb/typec_notify.h 
> b/include/linux/usb/typec_notify.h
> new file mode 100644
> index 000000000000..f3a7b5f5b05b
> --- /dev/null
> +++ b/include/linux/usb/typec_notify.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +
> +#ifndef __USB_TYPEC_NOTIFY
> +#define __USB_TYPEC_NOTIFY
> +
> +#include <linux/notifier.h>

Replace that include with a forward declaration:

struct notifier_block;

> +enum usb_typec_event {
> +     TYPEC_ALTMODE_REGISTERED,
> +     TYPEC_ALTMODE_UNREGISTERED,
> +};
> +
> +int typec_altmode_register_notify(struct notifier_block *nb);
> +int typec_altmode_unregister_notify(struct notifier_block *nb);
> +
> +#endif /* __USB_TYPEC_NOTIFY */

I don't see any need for a separate header file for this. Intoduce
those in typec_altmode.h.

thanks,

-- 
heikki