In practice it's not going to fail because we're passing the current
sanity checks done by drm_sched_entity_init(), and that's the only
reason it would return an error, but better safe than sorry.

v2:
- Add R-b

Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block")
Reviewed-by: Liviu Dudau <[email protected]>
Signed-off-by: Boris Brezillon <[email protected]>
---
 drivers/gpu/drm/panthor/panthor_sched.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/panthor/panthor_sched.c 
b/drivers/gpu/drm/panthor/panthor_sched.c
index 4216913ad7c9..33e04208db31 100644
--- a/drivers/gpu/drm/panthor/panthor_sched.c
+++ b/drivers/gpu/drm/panthor/panthor_sched.c
@@ -3430,6 +3430,8 @@ group_create_queue(struct panthor_group *group,
 
        drm_sched = &queue->scheduler;
        ret = drm_sched_entity_init(&queue->entity, 0, &drm_sched, 1, NULL);
+       if (ret)
+               goto err_free_queue;
 
        return queue;
 
-- 
2.51.0

Reply via email to