Hi Marek,
On 02/11/2025 18:41, Marek Vasut wrote:
> Since commit e38e8391f30b ("drm/imagination: Use pwrseq for TH1520 GPU
> power management"), the driver calls power sequencing functions. Add
> missing dependency on POWER_SEQUENCING, otherwise the kernel may fail
> to build if the driver is built-in and POWER_SEQUENCING is a module
> with these linker errors:
>
> aarch64-linux-gnu-ld: Unexpected GOT/PLT entries detected!
> aarch64-linux-gnu-ld: Unexpected run-time procedure linkages detected!
> aarch64-linux-gnu-ld: drivers/gpu/drm/imagination/pvr_power.o: in function
> `pvr_power_off_sequence_pwrseq':
> pvr_power.c:(.text+0x70): undefined reference to `pwrseq_power_off'
> aarch64-linux-gnu-ld: drivers/gpu/drm/imagination/pvr_power.o: in function
> `pvr_power_on_sequence_pwrseq':
> pvr_power.c:(.text+0x88): undefined reference to `pwrseq_power_on'
> aarch64-linux-gnu-ld: drivers/gpu/drm/imagination/pvr_power.o: in function
> `pvr_power_init_pwrseq':
> pvr_power.c:(.text+0xb4): undefined reference to `devm_pwrseq_get'Thanks for the fix! I did send a similar patch[1] last month in response to a test bot report[2], but it slipped my mind to chase an Rb for it so it's never been applied. Do you mind if I take the earlier patch instead of this one, since it doesn't add a hard dependency on POWER_SEQUENCING? Cheers, Matt [1]: https://lore.kernel.org/dri-devel/[email protected]/ [2]: https://lore.kernel.org/oe-kbuild-all/[email protected]/ > > Fixes: e38e8391f30b ("drm/imagination: Use pwrseq for TH1520 GPU power > management") > Signed-off-by: Marek Vasut <[email protected]> > --- > Cc: David Airlie <[email protected]> > Cc: Frank Binns <[email protected]> > Cc: Maarten Lankhorst <[email protected]> > Cc: Matt Coster <[email protected]> > Cc: Maxime Ripard <[email protected]> > Cc: Simona Vetter <[email protected]> > Cc: Thomas Zimmermann <[email protected]> > Cc: [email protected] > Cc: [email protected] > --- > drivers/gpu/drm/imagination/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/imagination/Kconfig > b/drivers/gpu/drm/imagination/Kconfig > index 682dd2633d0c..40ee08f72995 100644 > --- a/drivers/gpu/drm/imagination/Kconfig > +++ b/drivers/gpu/drm/imagination/Kconfig > @@ -7,6 +7,7 @@ config DRM_POWERVR > depends on DRM > depends on MMU > depends on PM > + depends on POWER_SEQUENCING > select DRM_EXEC > select DRM_GEM_SHMEM_HELPER > select DRM_SCHED -- Matt Coster E: [email protected]
OpenPGP_signature.asc
Description: OpenPGP digital signature
