On 10/20/25 2:30 PM, Miguel Ojeda wrote: > Hi Joel, > > A few nits below (I do sometimes this kind of docs review to try to > keep a consistent style across all Rust code). > > On Mon, Oct 20, 2025 at 8:56 PM Joel Fernandes <[email protected]> wrote: >> >> +//! .set_table_frame_number(new_table.frame_number()); >> +//! // Call a function to write PDE to VRAM address > > Newline between these. Period ad the end. >
Hi Miguel, As Joel also was hinting at, is there any easy way to get this sort of thing automatically checked? This is what scripts/checkpatch.pl helps us out with on the C side, and maybe it is also the right tool for Rust...? It's sad to have a patchset pass both checkpatch.pl, and CLIPPY=1 builds, and yet still be full of typography and convention violations. thanks, -- John Hubbard
