> Subject: [PATCH v2 01/10] drm/i915/alpm: Add dpcd definition for DP2.1 alpm
> capability

*DPCD
*ALPM

Try to keep abbreviation in uppercase

> 
> Add required dpcd address which will be needed to enable DP2.1 alpm.

Diito 

Otherwise LGTM,
Reviewed-by: Suraj Kandpal <[email protected]>

> 
> Cc: Jouni Högander <[email protected]>
> Signed-off-by: Animesh Manna <[email protected]>
> ---
>  include/drm/display/drm_dp.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h
> index e4eebabab975..b4bacbcf130e 100644
> --- a/include/drm/display/drm_dp.h
> +++ b/include/drm/display/drm_dp.h
> @@ -1512,6 +1512,8 @@
>  /* See DP_128B132B_SUPPORTED_LINK_RATES for values */
>  #define DP_PHY_REPEATER_128B132B_RATES                           0xf0007 /*
> 2.0 */
>  #define DP_PHY_REPEATER_EQ_DONE                             0xf0008 /* 2.0 
> E11 */
> +#define DP_LTTPR_ALPM_CAPABILITIES                          0xf0009 /* 2.1 */
> +#define DP_TOTAL_LTTPR_CNT                                  0xf000a /* 2.1 */
> 
>  enum drm_dp_phy {
>       DP_PHY_DPRX,
> @@ -1691,7 +1693,7 @@ enum drm_dp_phy {
>  #define DP_DSC_BRANCH_CAP_SIZE               3
>  #define EDP_PSR_RECEIVER_CAP_SIZE    2
>  #define EDP_DISPLAY_CTL_CAP_SIZE     5
> -#define DP_LTTPR_COMMON_CAP_SIZE     8
> +#define DP_LTTPR_COMMON_CAP_SIZE     10
>  #define DP_LTTPR_PHY_CAP_SIZE                3
> 
>  #define DP_SDP_AUDIO_TIMESTAMP               0x01
> --
> 2.29.0

Reply via email to