On Mon, Oct 20, 2025 at 06:06:44PM +0100, Kieran Bingham wrote: > Quoting Alok Tiwari (2025-10-17 20:16:21) > > The rcar_du_crtc_cleanup() function has a void return type, but > > incorrectly uses a return statement with a call to drm_crtc_cleanup(),
I don't know if it's incorrect as such, but it makes the code more readable. Reviewed-by: Laurent Pinchart <[email protected]> > > which also returns void. > > > > Remove the return statement to ensure proper function semantics. > > No functional change intended. > > > > Signed-off-by: Alok Tiwari <[email protected]> > > --- > > drivers/gpu/drm/renesas/rcar-du/rcar_du_crtc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_crtc.c > > b/drivers/gpu/drm/renesas/rcar-du/rcar_du_crtc.c > > index 7e175dbfd892..22bcd7db4195 100644 > > --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_crtc.c > > +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_crtc.c > > @@ -993,7 +993,7 @@ static void rcar_du_crtc_cleanup(struct drm_crtc *crtc) > > This cleanup is called through .destroy which is: > void (*destroy)(struct drm_crtc *crtc); > > > rcar_du_crtc_crc_cleanup(rcrtc); > > > > - return drm_crtc_cleanup(crtc); > > + drm_crtc_cleanup(crtc); > > and drm_crtc_cleanup is: > void drm_crtc_cleanup(struct drm_crtc *crtc) > > So it certainly can't return anything: > > Reviewed-by: Kieran Bingham <[email protected]> > > > } > > > > static void rcar_du_crtc_reset(struct drm_crtc *crtc) -- Regards, Laurent Pinchart
