Kamil, 

> On 4 Nov 2025, at 18:04, Boris Brezillon <[email protected]> 
> wrote:
> 
> On Tue,  4 Nov 2025 17:28:43 -0300
> Daniel Almeida <[email protected]> wrote:
> 
>> +igt_main {
>> + int fd;
>> +
>> + igt_fixture {
>> + fd = drm_open_driver(DRIVER_PANTHOR);
>> + }
>> +
>> + igt_describe("Create and destroy a CSF group.");
>> + igt_subtest("group_create") {
>> + struct drm_panthor_vm_create vm_create = {};
>> + struct drm_panthor_vm_destroy vm_destroy = {};
>> + uint32_t group_handle;
>> +
>> + vm_create.flags = 0;
>> + do_ioctl(fd, DRM_IOCTL_PANTHOR_VM_CREATE, &vm_create);
>> + igt_assert_neq(vm_create.id, 0);
>> +
>> + group_handle = igt_panthor_group_create_simple(fd, vm_create.id, 0);
>> + igt_assert_neq(group_handle, 0);
>> +
>> + igt_panthor_group_destroy(fd, group_handle, 0);
>> +
>> + vm_destroy = (struct drm_panthor_vm_destroy) { .id = vm_create.id };
>> + do_ioctl(fd, DRM_IOCTL_PANTHOR_VM_DESTROY, &vm_destroy);
>> + }
>> +
>> + igt_describe("Submit a job to a group and wait for completion. "
>> + "The job writes a known value to a buffer object that is then "
>> + "mmaped and checked.");
> 
> nit: indentation is off ^
> 
> igt_describe("Submit a job to a group and wait for completion. "
>     "The job writes a known value to a buffer object that is then "
>     "mmaped and checked.");

What should I do here?

Usually sending new versions so soon would be confusing. Given it's a trivial
fix, can you do it while applying? If not, should I wait a few days so that
this collects a few more tags?

— Daniel

Reply via email to