Using a helper shrinks the code and separating the user and kernel slabs
is more secure.

Signed-off-by: Tvrtko Ursulin <[email protected]>
---
 drivers/gpu/drm/drm_gem.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index a1a9c828938b..df138375e864 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -798,15 +798,9 @@ int drm_gem_objects_lookup(struct drm_file *filp, void 
__user *bo_handles,
 
        *objs_out = objs;
 
-       handles = kvmalloc_array(count, sizeof(u32), GFP_KERNEL);
-       if (!handles) {
-               ret = -ENOMEM;
-               goto out;
-       }
-
-       if (copy_from_user(handles, bo_handles, count * sizeof(u32))) {
-               ret = -EFAULT;
-               drm_dbg_core(dev, "Failed to copy in GEM handles\n");
+       handles = vmemdup_array_user(bo_handles, count, sizeof(u32));
+       if (IS_ERR(handles)) {
+               ret = PTR_ERR(handles);
                goto out;
        }
 
-- 
2.48.0

Reply via email to