On 11/6/25 09:48, Krzysztof Kozlowski wrote:
On Tue, Nov 04, 2025 at 11:16:09PM +0100, David Heidelberg wrote:
Basic description for S6E3FC2X01 DDIC with attached panels
- Samsung AMS601NT22 6.01 inch, 1080x2160 pixels, 18:9 ratio
- Samsung AMS628NW01 6.28 inch, 1080x2280 pixels, 19:9 ratio
This panel has three supplies, while panel-simple-dsi is limited to one.
There is no user of this compatible, nor the compatible make sense.
There are. git grep samsung,sofef00, gives me two users.
Hmm, on -next I only see a single one:
$ grep samsung,sofef00 arch/*/boot/dts/ -R
arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts: compatible =
"samsung,sofef00";
Remove it from simple DSI panel definitions.
Can't you mark is deprecated at first ?
Signed-off-by: David Heidelberg <[email protected]>
..
additionalProperties: false
required:
- compatible
+ - power-supply
- reg
examples:
diff --git
a/Documentation/devicetree/bindings/display/panel/samsung,sofef00.yaml
b/Documentation/devicetree/bindings/display/panel/samsung,sofef00.yaml
new file mode 100644
index 0000000000000..527a10e3b798e
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/samsung,sofef00.yaml
@@ -0,0 +1,83 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/samsung,sofef00.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung SOFEF00 AMOLED DDIC
+
+description: The SOFEF00 is display driver IC with connected panel.
Description goes below maintainers, see example-schema.
+
+maintainers:
+ - David Heidelberg <[email protected]>
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+ compatible:
+ items:
+ - enum:
+ # Samsung 6.01 inch, 1080x2160 pixels, 18:9 ratio
+ - samsung,sofef00-ams601nt22
+ # Samsung 6.28 inch, 1080x2280 pixels, 19:9 ratio
+ - samsung,sofef00-ams628nw01
These were not in the old binding, so please explain in the commit msg
reasons for adding new front compatibles.
+ - const: samsung,sofef00
+
+ reg:
+ maxItems: 1
+
+ reset-gpios: true
Drop, not needed. It can stay required, though.
+
+ port: true
Drop
+
+ vddio-supply:
+ description: VDD regulator
+
+ vci-supply:
+ description: VCI regulator
+
+ poc-supply:
+ description: POC regulator
1st poc, then vci then vddio to keep it more-or-less sorted. Same in
required list.
+
+required:
+ - compatible
+ - reset-gpios
+ - vddio-supply
+ - vci-supply
+ - poc-supply
+
+unevaluatedProperties: false
Best regards,
Krzysztof
