> Subject: [v6 04/16] drm/i915/color: Add helper to create intel colorop > > From: Chaitanya Kumar Borah <[email protected]> > > Add intel colorop create helper > > v2: > - Make function names consistent (Jani) > - Remove redundant code related to colorop state > - Refactor code to separate files > > Signed-off-by: Chaitanya Kumar Borah <[email protected]> > Signed-off-by: Uma Shankar <[email protected]>
LGTM, Reviewed-by: Suraj Kandpal <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_colorop.c | 25 ++++++++++++++++++++ > drivers/gpu/drm/i915/display/intel_colorop.h | 2 ++ > 2 files changed, 27 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_colorop.c > b/drivers/gpu/drm/i915/display/intel_colorop.c > index eaab50d2d126..f2fc0d8780ce 100644 > --- a/drivers/gpu/drm/i915/display/intel_colorop.c > +++ b/drivers/gpu/drm/i915/display/intel_colorop.c > @@ -8,3 +8,28 @@ struct intel_colorop *to_intel_colorop(struct drm_colorop > *colorop) { > return container_of(colorop, struct intel_colorop, base); } > + > +struct intel_colorop *intel_colorop_alloc(void) { > + struct intel_colorop *colorop; > + > + colorop = kzalloc(sizeof(*colorop), GFP_KERNEL); > + if (!colorop) > + return ERR_PTR(-ENOMEM); > + > + return colorop; > +} > + > +struct intel_colorop *intel_colorop_create(enum intel_color_block id) { > + struct intel_colorop *colorop; > + > + colorop = intel_colorop_alloc(); > + > + if (IS_ERR(colorop)) > + return colorop; > + > + colorop->id = id; > + > + return colorop; > +} > diff --git a/drivers/gpu/drm/i915/display/intel_colorop.h > b/drivers/gpu/drm/i915/display/intel_colorop.h > index 23a29a565949..21d58eb9f3d0 100644 > --- a/drivers/gpu/drm/i915/display/intel_colorop.h > +++ b/drivers/gpu/drm/i915/display/intel_colorop.h > @@ -9,5 +9,7 @@ > #include "intel_display_types.h" > > struct intel_colorop *to_intel_colorop(struct drm_colorop *colorop); > +struct intel_colorop *intel_colorop_alloc(void); struct intel_colorop > +*intel_colorop_create(enum intel_color_block id); > > #endif /* __INTEL_COLOROP_H__ */ > -- > 2.50.1
