On Mon, 2025-11-17 at 16:32 +0100, Christian König wrote: > On 11/13/25 17:23, Philipp Stanner wrote: > > On Thu, 2025-11-13 at 15:51 +0100, Christian König wrote: > > > Using the inline lock is now the recommended way for dma_fence > > > implementations. > > > > > > So use this approach for the scheduler fences as well just in > > > case if > > > anybody uses this as blueprint for its own implementation. > > > > > > Also saves about 4 bytes for the external spinlock. > > > > So you changed your mind and want to keep this patch? > > Actually it was you who changed my mind. > > When we want to document that using the internal lock is now the norm > and all implementations should switch to that if possible we should > push as much as possible for using this in the driver common code as > well.
Mentioning that in a changelog would be neat. How is anyone else supposed to know whether you forgot or changed your mind? And have you tested this? Kernel build bot is firing warnings. And touching the scheduler's spinlocks makes me nervous in general <.< P.
