Re: [PATCH 6/9] iommufd: Have pfn_reader process DMABUF iopt_pages

[Jason Gunthorpe]

On Thu, Nov 13, 2025 at 03:39:46PM -0800, Nicolin Chen wrote:
> > @@ -1687,6 +1737,12 @@ static void __iopt_area_unfill_domain(struct 
> > iopt_area *area,
> >  
> >     lockdep_assert_held(&pages->mutex);
> >  
> > +   if (iopt_is_dmabuf(pages)) {
> > +           iopt_area_unmap_domain_range(area, domain, start_index,
> > +                                        last_index);
> > +           return;
> > +   }
> 
> Should it be:
>       if (iopt_is_dmabuf(pages) && !iopt_dmabuf_revoked(pages)) {
> ?

All callers have already done it, let's add an assertion though..

@@ -1873,6 +1873,8 @@ static void __iopt_area_unfill_domain(struct iopt_area 
*area,
        lockdep_assert_held(&pages->mutex);
 
        if (iopt_is_dmabuf(pages)) {
+               if (WARN_ON(iopt_dmabuf_revoked(pages)))
+                       return;
                iopt_area_unmap_domain_range(area, domain, start_index,
                                             last_index);
                return;

Jason