On Wed Nov 19, 2025 at 3:28 PM CET, Louis Chauvet wrote: > > > On 11/19/25 13:05, Luca Ceresoli wrote: >> of_drm_find_bridge() does not increment the returned bridge >> refcount. drm_of_find_bridge() is to be used as a replacement. >> >> Suggested-by: Maxime Ripard <[email protected]> >> Link: >> https://lore.kernel.org/dri-devel/20250319-stylish-lime-mongoose-0a18ad@houat/ >> Signed-off-by: Luca Ceresoli <[email protected]>
... >> @@ -1452,6 +1452,9 @@ EXPORT_SYMBOL(drm_of_find_bridge); >> * >> * @np: device node >> * >> + * This function is deprecated. Use drm_of_find_bridge() instead for proper >> + * refcounting. >> + * > > I think it should be more explicit that the refcounting is not done by > this function, like: > > This function is deprecated. The returned bridge is not refcounted, you > should not use drm_bridge_put(). Use drm_of_find_bridge() instead for > proper refcounting. OK. -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
