Hi, On 20/11/2025 16:07, Linus Walleij wrote: > On Thu, Nov 20, 2025 at 3:45 AM Laurent Pinchart > <[email protected]> wrote: > >>> But I digress. I think initially we should just look for a clean fix for >>> the platforms affected: >>> >>> - Add the implementation into the drivers? >>> - Add helpers to the core? >>> - Add a flag of some kind so the core can do the right thing? >> >> drm_atomic_helper_commit_modeset_enables_crtc_early() would be more >> cumbersome to implement manually in drivers as most of the functions it >> calls are not exported. drm_atomic_helper_commit_tail_crtc_early_late() >> shouldn't be difficult to implement in the MCDE driver. > > But the second patch patch adding > drm_atomic_helper_commit_modeset_disables_crtc_late() > would be needed for symmetry. > >>> I made a quick test with the flag approach, below. It's not many lines, >>> but... Ugh, it does feel like a hack. >> >> Without seeing the code I can already imagine how this would feel like a >> hack, so I agree not to go that way.
I didn't mean we shouldn't go that way. I think it's the best option so far for a fix. The partial diff was included in the mail, so the bulk of the code was there. Only part missing was adding the flag into the struct and setting it in the driver. > It seems we cannot reach consensus on a regression fix that doesn't > require large re-architecturing, so I'll go ahead and propose a > revert instead, it's the only sensible thing. I hope nothing breaks > from the revert... Well, that will break DSI and OLDI on a bunch of boards using TI SoCs, so we might need to revert more than that patch. But if they were already in v6.17, reverting would be a regression... And there are least these: f5b1819193667bf62c3c99d3921b9429997a14b2 5d91394f236167ac624b823820faf4aa928b889e that fix the ordering for Mediatek and Samsung. So my guess is that those also need to be reverted. I really think we should just add the flag to resolve the regression. We can then continue pondering on a design change to somehow manage the bridges better. Tomi
