> +static umode_t typec_is_visible(struct kobject *kobj, struct attribute
> *attr, int n)
> +{
> + if (is_typec_port(kobj_to_dev(kobj)->parent))Why look at the parent? Doesn't the device have a type that should show this? Otherwise, looks good to me. thanks, greg k-h
