Thanks for the review.
On 12/5/25 16:07, Rob Herring wrote:
On Mon, Dec 01, 2025 at 12:53:20PM +0100, Maud Spierings wrote:
The Maxim MAX25014 is a 4-channel automotive grade backlight driver IC
with integrated boost controller.
Signed-off-by: Maud Spierings <[email protected]>
---
In the current implementation the control registers for channel 1,
control all channels. So only one led subnode with led-sources is
supported right now. If at some point the driver functionality is
expanded the bindings can be easily extended with it.
What's the relationship between the LEDs and backlight? It's a backlight
plus LEDs or just 4 identical channels.
it is just 4 identical channels, represented as leds, or in this case 1
led. I still feel a bit weird about this representation when there is
also led-backlight. But it was requested to map it in this way.
---
.../bindings/leds/backlight/maxim,max25014.yaml | 107 +++++++++++++++++++++
MAINTAINERS | 5 +
2 files changed, 112 insertions(+)
diff --git
a/Documentation/devicetree/bindings/leds/backlight/maxim,max25014.yaml
b/Documentation/devicetree/bindings/leds/backlight/maxim,max25014.yaml
new file mode 100644
index 000000000000..e83723224b07
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/backlight/maxim,max25014.yaml
@@ -0,0 +1,107 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/backlight/maxim,max25014.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim max25014 backlight controller
+
+maintainers:
+ - Maud Spierings <[email protected]>
+
+properties:
+ compatible:
+ enum:
+ - maxim,max25014
+
+ reg:
+ maxItems: 1
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+ enable-gpios:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ power-supply:
+ description: Regulator which controls the boost converter input rail.
+
+ pwms:
+ maxItems: 1
+
+ maxim,iset:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ maximum: 15
+ default: 11
+ description:
+ Value of the ISET field in the ISET register. This controls the current
+ scale of the outputs, a higher number means more current.
We have properties for setting the current (in uA). That can't work
here?
please refer to [1] and [2].
Link:
https://lore.kernel.org/all/[email protected]/
[1]
Link:
https://lore.kernel.org/all/20251009-overjoyed-unpopular-54f69e9bd82c@spud/
[2]
kind regards,
Maud
