On Mon, 2025-12-08 at 18:26 +0900, Alexandre Courbot wrote:
> /// Loads the FWSEC firmware into `falcon` and execute it.
> - pub(crate) fn run(
> - &self,
> - dev: &Device<device::Bound>,
> - falcon: &Falcon<Gsp>,
> - bar: &Bar0,
> - ) -> Result<()> {
> + pub(crate) fn run(&self, dev: &Device, falcon: &Falcon<Gsp>, bar: &Bar0)
> -> Result<()> {
I frequently see patches that, when they change the function signature,
rearrange the parameters
from one line to multiple lines. Here, you are doing the opposite. Not only
that, but it seems
unnecessary because you're actually just changing one parameter, so you should
only be replacing
one line.
It seems to me that some people have their editors configured to prefer one
line, and others
have their editor configured to prefer multiple lines, so whenever there's a
signature change,
we get diffs like this.
