> On Dec 15, 2025, at 9:57 PM, Alexandre Courbot <[email protected]> wrote: > > This series contains a few fixups for the recently merged GSP > command-queue code, by order of importance: > > - Some explicit padding required to safely implement `AsBytes` was > missing in the bindings, > - A bug in the received message length calculation results in the > message handler being given more data than it should, > - `MaybeZeroable` is now derived by the kernel's bindgen, but the Nova > bindings have not been updated for that, > - Some items in the bindings were referred to using the version module > directly, instead of the alias we defined to limit the diff when we > upgrade firmware versions. > > All of them address "bugs" (with the first two fixing actual correctness > issues), but since Nova does not do much anyway, they are also not > absolutely critical. Other series planned for this cycle will depend on > them, so one way or the other it would be great to see them in > drm-rust-next. > > Signed-off-by: Alexandre Courbot <[email protected]> > --- > Changes in v3: > - Rebase on top of drm-rust-next. > - Add method to return the payload size of a message. (thanks Alistair!) > - Link to v2: > https://patch.msgid.link/[email protected] > > Changes in v2: > - Add missing "Fixes:" tags. > - Link to v1: > https://lore.kernel.org/r/[email protected] > > --- > Alexandre Courbot (4): > gpu: nova-core: bindings: add missing explicit padding > gpu: nova-core: gsp: fix length of received messages > gpu: nova-core: bindings: derive `MaybeZeroable` > gpu: nova-core: gsp: replace firmware version with "bindings" alias
Reviewed-by: Joel Fernandes <[email protected]> thanks, - Joel > > drivers/gpu/nova-core/gsp/cmdq.rs | 10 ++- > drivers/gpu/nova-core/gsp/fw.rs | 78 ++++++++-------- > drivers/gpu/nova-core/gsp/fw/r570_144.rs | 11 ++- > drivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs | 105 ++++++++++++---------- > 4 files changed, 110 insertions(+), 94 deletions(-) > --- > base-commit: 60c7398bded2e11f0db40a409a241b8be5910ee2 > change-id: 20251121-nova-fixes-dc9b4f17b90e > > Best regards, > -- > Alexandre Courbot <[email protected]> >
