On Thu, Dec 18, 2025 at 12:19:32AM +0000, Dale Whinham wrote: > The MSM DRM driver currently does not support panels which report their > supported link rates via the SUPPORTED_LINK_RATES table. > > For panels which do not offer the optional eDP v1.3 fallback via > MAX_LINK_RATE, this will cause a panel probe failure (e.g. Samsung > ATNA30DW01-1 as found in Microsoft Surface Pro 11). > > Detect eDP v1.4 panels and parse the SUPPORTED_LINK_RATES table when > present. > > Additionally, set the rate using LINK_RATE_SET instead of LINK_BW_SET, > but only if LINK_BW_SET hasn't already been written to. > > Signed-off-by: Dale Whinham <[email protected]> > Tested-by: Jérôme de Bretagne <[email protected]> > Tested-by: Steev Klimaszewski <[email protected]> > --- > Changes in v2: > - Re-ordered writing of LANE_COUNT_SET/LINK_BW_SET registers to match i915 > [Dmitry] > - Fix detection of eDP by reading EDP_CONFIGURATION_CAP and EDP_REV (in v1 we > were mistakenly checking DPCD_REV) [Dmitry] > - Link to v1: > https://lore.kernel.org/r/[email protected] > --- > drivers/gpu/drm/msm/dp/dp_ctrl.c | 56 ++++++++++++++--------- > drivers/gpu/drm/msm/dp/dp_link.h | 3 ++ > drivers/gpu/drm/msm/dp/dp_panel.c | 93 > ++++++++++++++++++++++++++++++++++----- > 3 files changed, 120 insertions(+), 32 deletions(-) >
Reviewed-by: Dmitry Baryshkov <[email protected]> -- With best wishes Dmitry
