This works the same as FreeSync over PCON just without sending FreeSync
info packets (we're sending standard DisplayPort info packets) + reading
the VRR range from the HDMI Forum vendor specific data block. PCONs take
over HDMI VRR triggering.

Prefer HDMI VRR over FreeSync to reduce VRR flickering on many TVs.
FreeSync over HDMI seems to be a fallback solution and not a first-class
citizen. This especially helps VMM7100.

Tested with VMM7100 and CH7218 based adapters on multiple HDMI 2.1 and
HDMI 2.0 devices. (Samsung S95B, LG C4, Sony Bravia 8, Dell AW3423DWF)

Signed-off-by: Tomasz Pakuła <[email protected]>
Tested-by: Bernhard Berger <[email protected]>
---
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 20 ++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 1318d88687ae..7860779d7ede 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -12932,6 +12932,7 @@ void amdgpu_dm_update_freesync_caps(struct 
drm_connector *connector,
        struct dc_sink *sink;
        struct amdgpu_device *adev = drm_to_adev(connector->dev);
        struct amdgpu_hdmi_vsdb_info vsdb_info = {0};
+       struct drm_hdmi_vrr_cap *hdmi_vrr;
        const struct edid *edid;
        bool freesync_capable = false;
        enum adaptive_sync_type as_type = ADAPTIVE_SYNC_TYPE_NONE;
@@ -13004,21 +13005,34 @@ void amdgpu_dm_update_freesync_caps(struct 
drm_connector *connector,
                as_type = 
dm_get_adaptive_sync_support_type(amdgpu_dm_connector->dc_link);
 
        if (as_type == ADAPTIVE_SYNC_TYPE_PCON_IN_WHITELIST) {
+               hdmi_vrr = &connector->display_info.hdmi.vrr_cap;
                i = parse_hdmi_amd_vsdb(amdgpu_dm_connector, edid, &vsdb_info);
-               if (i >= 0 && vsdb_info.freesync_supported && 
vsdb_info.amd_vsdb_version > 0) {
 
+               /* Prefer HDMI VRR over FreeSync */
+               if (hdmi_vrr->supported) {
+                       amdgpu_dm_connector->pack_sdp_v1_3 = true;
+                       amdgpu_dm_connector->as_type = as_type;
+
+                       amdgpu_dm_connector->min_vfreq = hdmi_vrr->min_hz;
+                       amdgpu_dm_connector->max_vfreq = hdmi_vrr->max_hz;
+
+                       connector->display_info.monitor_range.min_vfreq = 
hdmi_vrr->min_hz;
+                       connector->display_info.monitor_range.max_vfreq = 
hdmi_vrr->max_hz;
+
+               } else if (i >= 0 && vsdb_info.freesync_supported && 
vsdb_info.amd_vsdb_version > 0) {
                        amdgpu_dm_connector->pack_sdp_v1_3 = true;
                        amdgpu_dm_connector->as_type = as_type;
                        amdgpu_dm_connector->vsdb_info = vsdb_info;
 
                        amdgpu_dm_connector->min_vfreq = 
vsdb_info.min_refresh_rate_hz;
                        amdgpu_dm_connector->max_vfreq = 
vsdb_info.max_refresh_rate_hz;
-                       if (amdgpu_dm_connector->max_vfreq - 
amdgpu_dm_connector->min_vfreq > 10)
-                               freesync_capable = true;
 
                        connector->display_info.monitor_range.min_vfreq = 
vsdb_info.min_refresh_rate_hz;
                        connector->display_info.monitor_range.max_vfreq = 
vsdb_info.max_refresh_rate_hz;
                }
+
+               if (amdgpu_dm_connector->max_vfreq - 
amdgpu_dm_connector->min_vfreq > 10)
+                       freesync_capable = true;
        }
 
 update:
-- 
2.52.0

Reply via email to