Drivers using drm_writeback_connector_init() / _with_encoder() don't perform cleanup in a manner similar to drmm_writeback_connector_init() (see drm_writeback_connector_cleanup()). Migrate all existing drivers to use drmm_writeback_connector_init(), drop drm_writeback_connector_init() and drm_writeback_connector::encoder (it's unused afterwards).
This series leaves former drm_writeback_connector_init_with_encoder() (renamed to drm_writeback_connector_init as a non-managed counterpart for drmm_writeback_connector_init()). It is supposed to be used by drivers which can not use drmm functions (like Intel). However I think it would be better to drop it completely. Note: Christophe pointed out that AMDGPU driver leaks connector memory. As it's not related to this series (and as I don't have enough proficiency in the driver) I'm not going to fix those in this series. Signed-off-by: Dmitry Baryshkov <[email protected]> --- Changes in v4: - Rebase on top of drm-misc-next, dropping applied patch. - Added a note regarding memory leak in the AMDGPU driver. - Fixed a devm vs drmm issue in the msm/dpu driver. - Link to v3: https://lore.kernel.org/r/[email protected] Changes in v3: - Fixed subject prefix for the rcar-du patch (Jessica Zhang) - Link to v2: https://lore.kernel.org/r/[email protected] Changes in v2: - Switched to drm_crtc_mask() where applicable (Louis Chauvet) - Link to v1: https://lore.kernel.org/r/[email protected] --- Dmitry Baryshkov (8): drm/msm/dpu: don't mix devm and drmm functions drm/amd/display: use drmm_writeback_connector_init() drm/komeda: use drmm_writeback_connector_init() drm/mali: use drmm_writeback_connector_init() drm: renesas: rcar-du: use drmm_writeback_connector_init() drm/vc4: use drmm_writeback_connector_init() drm: writeback: drop excess connector initialization functions drm: writeback: rename drm_writeback_connector_init_with_encoder() drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c | 18 ++++-- .../drm/arm/display/komeda/komeda_wb_connector.c | 30 ++++++---- drivers/gpu/drm/arm/malidp_mw.c | 25 ++++---- drivers/gpu/drm/drm_writeback.c | 69 +++------------------- drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 3 +- .../gpu/drm/renesas/rcar-du/rcar_du_writeback.c | 23 +++++--- drivers/gpu/drm/vc4/vc4_txp.c | 9 ++- include/drm/drm_writeback.h | 22 +------ 9 files changed, 76 insertions(+), 125 deletions(-) --- base-commit: 130343ee6bca9895c47d314467db7dd3dcc8bc35 change-id: 20250801-wb-drop-encoder-97a0c75bd5d7 Best regards, -- With best wishes Dmitry
