On Mon, Dec 29, 2025 at 12:53 PM Marijn Suijten <[email protected]> wrote:
> > Yes that's what I suspect. > > Do you still want me to drop it from the compatible, but definitely keep it in > the driver filename unless we unify all of the drivers (hopefully in a later > patch)? The compatible should be as precise as possible, so indicate the assembled display with display controller, typically samsung,ams605dk01 etc, then the Linux driver is basically a Linux intrinsic matter, but we would name that after the display controller so as to make the basis of code sharing obvious between the compatibles. > > > Also, divergence of the driver commands got significant with the last two > > > panels > > > / three phones, though that might be down to vendor > > > configuration/calibration. > > > > That's kind of normal. The defaults suffice for a while, then engineers > > want to start poking at different voltages to the display to improve > > and tweak things. > > Makes one wonder if the changes are down to the panel used, or vendor tuning > when they started using these panels in their phones. To note, I think I > booted > all these phones on the "original" SOFEF01 driver without problems, before > ultimately implementing all diverging commands because I don't know if they're > defaults, related to color tuning, timings, thermals, manufacturer tolerances > or > anything else. Yeah a datasheet would really help :/ Samsung, if you're reading this, you know what to do: give us the datasheets, pretty please with sugar on top. Yours, Linus Walleij
