Hi, On Tue, Dec 30, 2025 at 9:20 AM Robin Murphy <[email protected]> wrote: > > FriendlyELEC's HD702E module is an eDP panel (in as much as it's some > LVDS LCD behind a Chrontel CH7511B eDP bridge), so move its data over > to the eDP driver, also resolving the warning about the missing bpc > value in the process. > > Signed-off-by: Robin Murphy <[email protected]> > --- > drivers/gpu/drm/panel/panel-edp.c | 26 ++++++++++++++++++++++++++ > drivers/gpu/drm/panel/panel-simple.c | 25 ------------------------- > 2 files changed, 26 insertions(+), 25 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-edp.c > b/drivers/gpu/drm/panel/panel-edp.c > index 415b894890ad..dd53ccc209ce 100644 > --- a/drivers/gpu/drm/panel/panel-edp.c > +++ b/drivers/gpu/drm/panel/panel-edp.c > @@ -1256,6 +1256,29 @@ static const struct panel_desc boe_nv140fhmn49 = { > }, > }; > > +static const struct drm_display_mode friendlyarm_hd702e_mode = { > + .clock = 67185, > + .hdisplay = 800, > + .hsync_start = 800 + 20, > + .hsync_end = 800 + 20 + 24, > + .htotal = 800 + 20 + 24 + 20, > + .vdisplay = 1280, > + .vsync_start = 1280 + 4, > + .vsync_end = 1280 + 4 + 8, > + .vtotal = 1280 + 4 + 8 + 4, > + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, > +}; > + > +static const struct panel_desc friendlyarm_hd702e = { > + .modes = &friendlyarm_hd702e_mode, > + .num_modes = 1, > + .bpc = 8, > + .size = { > + .width = 94, > + .height = 151, > + }, > +}; > + > static const struct drm_display_mode innolux_n116bca_ea1_mode = { > .clock = 76420, > .hdisplay = 1366, > @@ -1663,6 +1686,9 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "boe,nv140fhmn49", > .data = &boe_nv140fhmn49, > + }, { > + .compatible = "friendlyarm,hd702e", > + .data = &friendlyarm_hd702e,
Do you actually need this? I notice that in the DTS patch you've got things under the DP AUX bus, which should enable you to use the generic "edp-panel" compatible string assuming the EDID is populated properly and there are no problems with power sequencing. IMO the only reasons we should be adding new entries to "platform_of_match" these days is if we need to work with some legacy eDP controller that can't be updated to handle the DP AUX BUS or we've got a controller with a bogus EDID... -Doug
